-
Notifications
You must be signed in to change notification settings - Fork 280
Add kueue component #6358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add kueue component #6358
Conversation
b487ab0
to
15622d6
Compare
/test konflux-e2e-v416-optional |
/test |
@gbenhaim: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test appstudio-e2e-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions and comments, but mostly looks fine by me.
argo-cd-apps/base/member/infra-deployments/cert-manager/cert-manager.yaml
Outdated
Show resolved
Hide resolved
roleRef: | ||
apiGroup: rbac.authorization.k8s.io | ||
kind: ClusterRole | ||
name: admin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to grant this service account admin
rights on the namespace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's used to run a job which installs the operator in the namespace, usually only admin has the rights to install operators. It would be difficult to pinpoint the exact permissions it needs on the namespace (and even than those would be broad).
requests: | ||
cpu: "100m" | ||
memory: "128Mi" | ||
limits: | ||
cpu: "200m" | ||
memory: "256Mi" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we set the requests and the limits to be the same to avoid pod evictions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it was done on the initContainer
, but not on this container?
448b7d4
to
dad9ff1
Compare
/test konflux-e2e-v416-optional |
1 similar comment
/test konflux-e2e-v416-optional |
dad9ff1
to
b653014
Compare
/test konflux-e2e-v416-optional |
b653014
to
994ff0f
Compare
/test konflux-e2e-v416-optional |
994ff0f
to
dc47888
Compare
/test konflux-e2e-v416-optional |
1 similar comment
/test konflux-e2e-v416-optional |
dc47888
to
c8b44fe
Compare
/test konflux-e2e-v416-optional |
c8b44fe
to
881f983
Compare
/test konflux-e2e-v416-optional |
- Add the manifests for deploying Kueue using the RH operator. Since wasn't released yet (and it doesn't have an index image), use operator-sdk for installing it. - Add the ArgoCD AppSet for Kueue. Signed-off-by: Gal Ben Haim <[email protected]>
Signed-off-by: Gal Ben Haim <[email protected]>
The configmap is used for telling the admission controller if it need to admit workloads. This is a temporary solution until the integration with alert manager will by implemented. Signed-off-by: Gal Ben Haim <[email protected]>
It's not possible to install it on earlier versions. Signed-off-by: Gal Ben Haim <[email protected]>
Signed-off-by: Gal Ben Haim <[email protected]>
Signed-off-by: Gal Ben Haim <[email protected]>
Signed-off-by: Gal Ben Haim <[email protected]>
Signed-off-by: Gal Ben Haim <[email protected]>
Signed-off-by: Gal Ben Haim <[email protected]>
Configure the Pipelineruns queues on the cluster. - LocalQueue for each tenant - created by Kyverno - A global cluster queue configured with admission check provided by kueue-external-admission. Signed-off-by: Gal Ben Haim <[email protected]>
- tekton-kueue - kueue-external-admission Signed-off-by: Gal Ben Haim <[email protected]>
Adding the defaults so Argo won't think that resource is out of sync. Signed-off-by: Gal Ben Haim <[email protected]>
Signed-off-by: Gal Ben Haim <[email protected]>
Signed-off-by: Gal Ben Haim <[email protected]>
Signed-off-by: Gal Ben Haim <[email protected]>
4848002
to
e264b2b
Compare
/test konflux-e2e-v416-optional |
1 similar comment
/test konflux-e2e-v416-optional |
When a Workload doesn't have cpu or memory requests, if there is a limit range in the namespace, Kueue will assign the requests from it to the Workload. We don't care about the cpu/memory for PipelineRuns, thus setting a high value for both. Signed-off-by: Gal Ben Haim <[email protected]>
Signed-off-by: Gal Ben Haim <[email protected]>
6efeaf5
to
f15ead2
Compare
/test konflux-e2e-v416-optional |
3 similar comments
/test konflux-e2e-v416-optional |
/test konflux-e2e-v416-optional |
/test konflux-e2e-v416-optional |
Signed-off-by: Gal Ben Haim <[email protected]>
/test konflux-e2e-v416-optional |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gbenhaim, hugares The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM |
Install kueue and the plugins for supporting tekton pipelineruns and external admission.
Install only as part of the development overlay and only on OCP cluster with version >= 4.16 (the kueue operator doesn't work on earlier version).
ATM, the index image for the RH productized version of Kueue isn't yet ready, because of that it's being installed using the
operator-framework
cli.